ASoC: SOF: refine sof for multi-channels support - #39
Conversation
There was a problem hiding this comment.
Cant do this string checking, best to have separate info() calls for volume and switch
There was a problem hiding this comment.
Yes, I will refine it. And I also checked the Asoc, the info function would be bound only for volume case
There was a problem hiding this comment.
Should this info be appended to SOF_TPLG_KCTL_VOL_ID ?
There was a problem hiding this comment.
yes, I would do this. I did this according to id, the smallest is in the head
plbossart
left a comment
plbossart
left a comment
There was a problem hiding this comment.
Can you please clarify the commit message. Your use of the word 'hook' isn't clear and there are missing words/grammar issues making the message difficult to understand. Thanks.
9c3f222 to
ebb71bd
Compare
|
Update my comments and patch |
There was a problem hiding this comment.
This should be a separate fix in it's own PR.
There was a problem hiding this comment.
Can you rebase and repush, I don't see why this change is still visible.
There was a problem hiding this comment.
Still not following why we need to override a standard kcontrol ID here.
There was a problem hiding this comment.
I also don't get what this is about?
There was a problem hiding this comment.
@plbossart @lgirdwood please refer to thesofproject/soft#34
plbossart
left a comment
plbossart
left a comment
There was a problem hiding this comment.
It looks like there are still pending opens on this PR, please rebase/push and answer to questions in the comments.
There was a problem hiding this comment.
Can you rebase and repush, I don't see why this change is still visible.
There was a problem hiding this comment.
I also don't get what this is about?
User mode lib calls info function in kcontrol to get the channel number of volume mixer. The default info function is snd_soc_info_volsw which only supports max two channels. Just like get/put function, info function is bound to a bespoke info function in SOF and return correct channel number to user. The snd_sof_volume_info is based on snd_soc_info_volsw, and refines the channel setting. Using standard SND_SOC_TPLG_CTL_VOLSW to register our kcontrol function because only it supports binding all kcontrol functions to bespoke ones. And this change doesn't affect the volume mixer which is not created by topology and doesn't affect the topology released Signed-off-by: Rander Wang <rander.wang@linux.intel.com>
|
Refine my patch. The detail of this change is discussing in thesofproject/soft#34 |
3 participants
User mode lib calls info function in kcontrol to get the channel number of
volume mixer. The default info function is snd_soc_info_volsw which only
supports max two channels. Just like get/put function, info function is
bound to a bespoke info function in SOF and return correct channel number
to user.
The snd_sof_volume_info is based on snd_soc_info_volsw, and refines the
channel setting. Using standard SND_SOC_TPLG_CTL_VOLSW to register our
kcontrol function because only it supports binding all kcontrol functions to bespoke
ones. And this change doesn't affect the volume mixer which is not created by
topology and doesn't affect the topology released
Signed-off-by: Rander Wang rander.wang@linux.intel.com